chore(clerk-js): Remove Clerk.commerce #5846
Conversation
🦋 Changeset detectedLatest commit: 05afd9c The changes in this PR will be included in the next version bump. This PR includes changesets to release 22 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
LekoArts
left a comment
LekoArts
left a comment
There was a problem hiding this comment.
I think you should also update https://github.com/clerk/javascript/blob/main/.changeset/witty-doors-hear.md because otherwise the changelog is quite confusing. Then the new changeset you can keep minimal as the old one will show the correct one
panteliselef
left a comment
panteliselef
left a comment
There was a problem hiding this comment.
Looks good, left some comments about invariant
|
|
||
| const subscriber = () => { | ||
| if (ctx.subscriberType === 'org' && clerk.organization) { | ||
| invariant(clerk.organization, 'Clerk: subscriberType is "org" but no active organization was found'); |
There was a problem hiding this comment.
Should we handle this inside the mount/open singleton methods instead ?
There was a problem hiding this comment.
This is mostly to make types happy without casting, agreed it shouldn't really be necessary in practice
| return clerk.organization; | ||
| } | ||
|
|
||
| invariant(clerk.user, 'Clerk: no active user found'); |
There was a problem hiding this comment.
Do we need this ? openCheckout will not mount any component if user is signed out.
There was a problem hiding this comment.
Shouldn't be necessary I agree, it's mostly done to satisfy types in this usage.
Description
Removes the
Clerk.commercenamespace in favor of justClerk.billing. The payment source methods that lived underClerk.commercehave been moved toClerk.userandClerk.organization.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change