Skip to content

Conversation

@radblesk
Copy link
Contributor

@radblesk radblesk commented Apr 1, 2025

Description

I have updated sk-SK localization file with the following:

  • Added translations to experimental_commerce
  • Added translations to formField placeholders
  • Added translations to Organizations - list, profile,...
  • Added translations to Personal Account - profile, actions,...
  • Added translations to waitlist
  • Updated some incorrect translations

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other: Localization update

Summary by CodeRabbit

  • New Features

    • Added comprehensive Slovak translations across the user interface, including commerce, organization management, authentication flows, user profiles, billing, error messages, and waitlist components.
  • Enhancements

    • Improved localization consistency by replacing English or missing strings with accurate Slovak equivalents throughout the application.

@changeset-bot
Copy link

changeset-bot bot commented Apr 1, 2025

🦋 Changeset detected

Latest commit: 487266c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@clerk/localizations Patch
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Apr 1, 2025

@radblesk is attempting to deploy a commit to the Clerk Production Team on Vercel.

A member of the Team first needs to authorize it.

@clerk-cookie
Copy link
Collaborator

Hello 👋

We currently close PRs after 60 days of inactivity. It's been 50 days since the last update here. If we missed this PR, please reply here. Otherwise, we'll close this PR in 10 days.

Thanks for being a part of the Clerk community! 🙏

@radblesk
Copy link
Contributor Author

Is there any problem because of which my translations weren't added, did I do something wrong?

@clerk-cookie
Copy link
Collaborator

Hello 👋

We currently close PRs after 60 days of inactivity. It's been 50 days since the last update here. If we missed this PR, please reply here. Otherwise, we'll close this PR in 10 days.

Thanks for being a part of the Clerk community! 🙏

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 12, 2025

📝 Walkthrough

Walkthrough

The update enhances the Slovak localization resource file (sk-SK.ts) by providing Slovak translations for numerous previously missing or English placeholder strings. The changes cover a wide range of user interface elements, including commerce terms, form labels and placeholders, organization management features, sign-in and sign-up flows, error messages, user profile management, and waitlist components. No new logic or structural changes are introduced; the update strictly involves populating the localization resource with accurate Slovak text to replace undefined or English values. Exported or public entity declarations remain unchanged.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 61f1bc5 and 487266c.

📒 Files selected for processing (1)
  • packages/localizations/src/sk-SK.ts (37 hunks)
✅ Files skipped from review due to trivial changes (1)
  • packages/localizations/src/sk-SK.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: semgrep-cloud-platform/scan

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🔭 Outside diff range comments (1)
packages/localizations/src/sk-SK.ts (1)

43-48: Replace Czech word “Příští” with Slovak equivalent.

next6Days currently reads “Příští …”, which is Czech.
Use a Slovak form such as “Budúci” or “Nasledujúci” to stay consistent with the rest of the file.

-    next6Days: "Příští {{ date | weekday('sk-SK','long') }} o {{ date | timeString('sk-SK') }}",
+    next6Days: "Budúci {{ date | weekday('sk-SK','long') }} o {{ date | timeString('sk-SK') }}",
🧹 Nitpick comments (5)
packages/localizations/src/sk-SK.ts (5)

669-670: Typo – “Faturácia” → “Fakturácia”.

-      title: 'Faturácia a platby',
+      title: 'Fakturácia a platby',

918-922: Typo – “Nastaiť” → “Nastaviť”.

-        detailsAction__nonPrimary: 'Nastaiť ako hlavnú',
+        detailsAction__nonPrimary: 'Nastaviť ako hlavnú',

920-922: Consistency: “Web3 peňaženky” button label missing verb.

Consider adding “Pridať” for clarity.

-        primaryButton: 'Web3 peňaženky',
+        primaryButton: 'Pridať Web3 peňaženku',

601-603: Grammar – missing comma before “ale”.

-    passkey_pa_not_supported: 'Registrácia vyžaduje autentifikátor ale toto zariadenie ho nepodporuje.',
+    passkey_pa_not_supported: 'Registrácia vyžaduje autentifikátor, ale toto zariadenie ho nepodporuje.',

568-569: Style: “zabezpečenia” sounds unnatural here.

Prefer “bezpečnostného overenia”.

-      'Registrácia zlyhala z dôvodu neúspešného overenia zabezpečenia. Obnovte stránku a skúste to znova alebo kontaktujte podporu pre ďalšiu pomoc.',
+      'Registrácia zlyhala z dôvodu neúspešného bezpečnostného overenia. Obnovte stránku a skúste to znova alebo kontaktujte podporu pre ďalšiu pomoc.',
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a2e169e and 2d2fcb1.

📒 Files selected for processing (1)
  • packages/localizations/src/sk-SK.ts (28 hunks)
🧰 Additional context used
📓 Path-based instructions (7)
**/*.{js,jsx,ts,tsx}

Instructions used from:

Sources:
📄 CodeRabbit Inference Engine

  • .cursor/rules/development.mdc
packages/**/*.ts

Instructions used from:

Sources:
📄 CodeRabbit Inference Engine

  • .cursor/rules/development.mdc
packages/**/*.{ts,tsx,d.ts}

Instructions used from:

Sources:
📄 CodeRabbit Inference Engine

  • .cursor/rules/development.mdc
**/*.{ts,tsx}

Instructions used from:

Sources:
📄 CodeRabbit Inference Engine

  • .cursor/rules/development.mdc
  • .cursor/rules/typescript.mdc
packages/localizations/**/*

Instructions used from:

Sources:
📄 CodeRabbit Inference Engine

  • .cursor/rules/monorepo.mdc
**/*.ts

Instructions used from:

Sources:
⚙️ CodeRabbit Configuration File

**/*

Instructions used from:

Sources:
⚙️ CodeRabbit Configuration File

🔇 Additional comments (1)
packages/localizations/src/sk-SK.ts (1)

526-533: Placeholder links wording awkward.

The phrase “podmienkami o ochrane osobných údajov” should be “zásadami ochrany osobných údajov” for standard legal wording.

-        label__onlyPrivacyPolicy: 'Súhlasím s {{ privacyPolicyLink || link("podmienkami o ochrane osobných údajov") }}',
+        label__onlyPrivacyPolicy: 'Súhlasím so {{ privacyPolicyLink || link("zásadami ochrany osobných údajov") }}',

@tmilewski
Copy link
Member

Thanks, @radblesk!

@tmilewski tmilewski merged commit 4c3d6c1 into clerk:main Jul 18, 2025
3 of 4 checks passed
jacekradko pushed a commit that referenced this pull request Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants