Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clerk-js,types,localizations): Search members on OrganizationProfile #4942

Conversation

LauraBeatris
Copy link
Member

@LauraBeatris LauraBeatris commented Jan 20, 2025

Description

Resolves ORGS-469

Introduces the ability to search organization memberships within OrganizationProfile


Searching behavior

CleanShot.2025-01-21.at.08.23.58.mp4

UI with org:sys_memberships:manage permission

Preserves the "Invite" button action trigger instead of hiding it:

CleanShot.2025-01-21.at.08.27.30.mp4

UI without org:sys_memberships:manage permission

CleanShot 2025-01-21 at 08 13 38

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented Jan 20, 2025

🦋 Changeset detected

Latest commit: 9f595d1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 22 packages
Name Type
@clerk/localizations Patch
@clerk/clerk-js Patch
@clerk/shared Patch
@clerk/types Patch
@clerk/clerk-react Patch
@clerk/ui Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch
@clerk/astro Patch
@clerk/backend Patch
@clerk/elements Patch
@clerk/expo-passkeys Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/nextjs Patch
@clerk/nuxt Patch
@clerk/react-router Patch
@clerk/remix Patch
@clerk/tanstack-start Patch
@clerk/testing Patch
@clerk/vue Patch
@clerk/themes Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 9:21am

@LauraBeatris LauraBeatris force-pushed the laura/orgs-469-implement-searching-for-memberships-on-organizationprofile branch 5 times, most recently from 29a9d5a to b8d5435 Compare January 20, 2025 14:52
@LauraBeatris LauraBeatris force-pushed the laura/orgs-469-implement-searching-for-memberships-on-organizationprofile branch from b8d5435 to 95bf1c2 Compare January 20, 2025 14:56
@LauraBeatris LauraBeatris changed the title feat(clerk-js,types,localizations): Search memberships on OrganizationProfile feat(clerk-js,types,localizations): Search members on OrganizationProfile Jan 20, 2025
@LauraBeatris LauraBeatris force-pushed the laura/orgs-469-implement-searching-for-memberships-on-organizationprofile branch from a8461ba to e63e8fe Compare January 20, 2025 17:58
@LauraBeatris LauraBeatris force-pushed the laura/orgs-469-implement-searching-for-memberships-on-organizationprofile branch from f410377 to 292e10d Compare January 20, 2025 20:41
@LauraBeatris LauraBeatris force-pushed the laura/orgs-469-implement-searching-for-memberships-on-organizationprofile branch from 292e10d to 4d6498d Compare January 20, 2025 20:44
@LauraBeatris LauraBeatris force-pushed the laura/orgs-469-implement-searching-for-memberships-on-organizationprofile branch from 4d6498d to 670033e Compare January 20, 2025 20:47
@LauraBeatris LauraBeatris force-pushed the laura/orgs-469-implement-searching-for-memberships-on-organizationprofile branch from 670033e to 030cc25 Compare January 20, 2025 20:54
@LauraBeatris LauraBeatris self-assigned this Jan 20, 2025
@LauraBeatris LauraBeatris changed the title feat(clerk-js,types,localizations): Search members on OrganizationProfile [WIP] feat(clerk-js,types,localizations): Search members on OrganizationProfile Jan 20, 2025
@LauraBeatris LauraBeatris force-pushed the laura/orgs-469-implement-searching-for-memberships-on-organizationprofile branch from 39ce102 to 93e3e10 Compare January 23, 2025 19:29
Copy link
Member

@alexcarpenter alexcarpenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@LauraBeatris LauraBeatris force-pushed the laura/orgs-469-implement-searching-for-memberships-on-organizationprofile branch from 93e3e10 to 9f595d1 Compare January 24, 2025 09:19
@LauraBeatris LauraBeatris merged commit a26cf0f into main Jan 24, 2025
29 checks passed
@LauraBeatris LauraBeatris deleted the laura/orgs-469-implement-searching-for-memberships-on-organizationprofile branch January 24, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants