fix(elements): Types for step component #3359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a25f2eb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
LekoArts
commented
May 10, 2024
| @@ -18,7 +18,7 @@ import { | |||
| } from '~/react/sign-in/context'; | |||
| import { createContextFromActorRef } from '~/react/utils/create-context-from-actor-ref'; | |||
|
|
|||
| export type SignInVerificationsProps = { preferred?: ClerkSignInStrategy; children: React.ReactNode } & FormProps; | |||
| export type SignInVerificationsProps = { preferred?: ClerkSignInStrategy } & FormProps; | |||
There was a problem hiding this comment.
FormProps already marks children as required
tmilewski
approved these changes
May 10, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While writing the E2E tests I noticed a bug:
I couldn't apply
classNametoSignIn.Step name="choose-strategy"andSignIn.Step name="forgot-password". Looking at the types, yeah, they only acceptedchildren. They both didn't render any markup and were only Context wrappers.This PR adds
<div>as markup around these two steps and let's one apply their props to that.While running the build process I got warnings about circular deps for Elements so I removed the barrel file for the sign-in step component and moved files around.
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change