fix(clerk-js): UI fixes for phone input and OTP inputs #3302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: dd3ec07 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tmilewski
approved these changes
May 1, 2024
octoper
force-pushed
the
vaggelis/sdk-1704-core-2-components-ui-issues
branch
from
2ebd039
to
f047d0b
Compare
|
Did we check if these issues appear only without |
desiprisg
reviewed
May 2, 2024
| borderTopLeftRadius: 0, | ||
| borderBottomLeftRadius: 0, | ||
| paddingLeft: t.space.$1, | ||
| '&:focus': { |
There was a problem hiding this comment.
What about hover and active states?
There was a problem hiding this comment.
Hover and active states are not styled by default but we can include them as well
|
@desiprisg Yeah I have checked both and they had the same issues but those changes fixes them both |
octoper
force-pushed
the
vaggelis/sdk-1704-core-2-components-ui-issues
branch
from
f047d0b
to
dd3ec07
Compare
desiprisg
approved these changes
May 8, 2024
anagstef
approved these changes
May 8, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes 2 UI issues that were found when using
@tailwindcss/forms, the first problem was that phone number had the country code flowing over the phone input and the other one was that the OTP where huge due tobox-sizing: content-boxBefore
After
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change