chore(shared): Remove patch for swr-devtools #1794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3bbf63f The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
!snapshot |
|
Hey @panteliselef - the snapshot version command generated the following package versions:
Tip: use the snippet copy button below to quickly install the required packages. # @clerk/chrome-extension
npm i @clerk/[email protected]# @clerk/clerk-js
npm i @clerk/[email protected]# @clerk/clerk-expo
npm i @clerk/[email protected]# @clerk/fastify
npm i @clerk/[email protected]# gatsby-plugin-clerk
npm i [email protected]# @clerk/nextjs
npm i @clerk/[email protected]# @clerk/clerk-react
npm i @clerk/[email protected]# @clerk/remix
npm i @clerk/[email protected]# @clerk/shared
npm i @clerk/[email protected] |
panteliselef
changed the title
dimkl
approved these changes
Sep 28, 2023
Merged
|
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our patch was preventing swr-devtools from running with the react version the clerkjs components use, causing the hosting app to break.
This has now been patched from the maintainer of swr-devtools and in a setup where both patches run the devtools will alway be disabled.
This PR removes our patch and allows swr-devtools to run only for the hosting app (not hotloaded clerkjs components)
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/chore