Updated OnDrawingFinished hook to not be overwritten by other mods. #201
Conversation
source/CGameMenu.cpp
Outdated
| @@ -24,6 +24,8 @@ namespace CLEO | |||
|
|
|||
| void __fastcall OnDrawMenuBackground(void *texture, int dummy, RwRect2D *rect, RwRGBA *color) | |||
| { | |||
| GetInstance().Start(true); // late initialization | |||
There was a problem hiding this comment.
why is it called from here and not from OnScmInit1 for example?
There was a problem hiding this comment.
That would be very late. If level 3 of logging is enabled there are already messages to display in main menu.
Future ambient scripts will also log stuff right after game starts.
| CodeInjector.ReplaceFunction(OnFlushObrsPrintfs, address); | ||
| break; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
this should be a separate method, no need to increase complexity of an already long function
There was a problem hiding this comment.
Have single initialization function instead of two. After more thinking it should probably be made with variable int initializationStage, and incremented. So next stage can not be performed until previous was executed.
There was a problem hiding this comment.
no need to over-engineer simple stuff. please create a new method called setupOnDrawingHook and call it separately from the core init.
There was a problem hiding this comment.
Updated. There will be more things to initialize late. I had exact same need to start ModLoader system after all other asi plugins are loaded.
Hooking read string param function also can be considered to perform later.
Maybe that whole logic should be wrapped into SmartHook class.
MiranDMC
force-pushed
the
fix_2dfx_breaking_screen_log
branch
from
3c68bce to
2f4211a
Compare
Added late initialization phase for installing on drawing finished hook.
Fixes #169
Fixes missing prints with SkyGFX mnod installed too.