Skip to content

Audit Issue 21: Better unique message ID in Outbound Queue v2 #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
claravanstaden merged 3 commits into from
Apr 14, 2025
Merged

Audit Issue 21: Better unique message ID in Outbound Queue v2 #21

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5b131ab
better unique message id
claravanstaden Apr 10, 2025
78b7326
use blake2_256
claravanstaden Apr 10, 2025
57ffa85
Revert "use blake2_256"
claravanstaden Apr 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions bridges/snowbridge/pallets/system-v2/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,12 +228,10 @@ pub mod pallet {
fn send(origin: H256, command: Command, fee: u128) -> DispatchResult {
let mut message = Message {
origin,
id: Default::default(),
id: frame_system::unique((origin, command, fee)),
Copy link
Copy Markdown

@yrong yrong Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest using blake2_256 for determinism.

Copy link
Copy Markdown
Owner Author

@claravanstaden claravanstaden Apr 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in 78b7326.

Copy link
Copy Markdown

@vgeddes vgeddes Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think determinism is useful in this case. These are governance messages emitted by BridgeHub itself. I don't think any UIs are going to try and deterministically recreate these message ids.

Copy link
Copy Markdown
Owner Author

@claravanstaden claravanstaden Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted 78b7326.

fee,
commands: BoundedVec::try_from(vec![command]).unwrap(),
};
let hash = sp_io::hashing::blake2_256(&message.encode());
message.id = hash.into();

let ticket = <T as pallet::Config>::OutboundQueue::validate(&message)
.map_err(|err| Error::<T>::Send(err))?;
Expand Down
Loading