Audit Issue 21: Better unique message ID in Outbound Queue v2#21
Merged
claravanstaden merged 3 commits intosnowbridge-v2-audit-fixesfrom Apr 14, 2025
Merged
Audit Issue 21: Better unique message ID in Outbound Queue v2#21claravanstaden merged 3 commits intosnowbridge-v2-audit-fixesfrom
claravanstaden merged 3 commits intosnowbridge-v2-audit-fixesfrom
Conversation
yrong
reviewed
Apr 10, 2025
| let mut message = Message { | ||
| origin, | ||
| id: Default::default(), | ||
| id: frame_system::unique((origin, command, fee)), |
There was a problem hiding this comment.
I'd suggest using blake2_256 for determinism.
There was a problem hiding this comment.
I don't think determinism is useful in this case. These are governance messages emitted by BridgeHub itself. I don't think any UIs are going to try and deterministically recreate these message ids.
This reverts commit 78b7326.
|
Review required! Latest push from author must always be reviewed |
vgeddes
approved these changes
Apr 14, 2025
claravanstaden
merged commit 38f1aee
into
snowbridge-v2-audit-fixes
116 of 210 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: SNO-1474