Audit Issue 22: Optimize sparse bitmap#18
Merged
claravanstaden merged 3 commits intosnowbridge-v2-audit-fixesfrom Apr 11, 2025
Merged
Audit Issue 22: Optimize sparse bitmap#18claravanstaden merged 3 commits intosnowbridge-v2-audit-fixesfrom
claravanstaden merged 3 commits intosnowbridge-v2-audit-fixesfrom
Conversation
vgeddes
reviewed
Apr 11, 2025
| fn set(index: u64); | ||
| } | ||
|
|
||
| /// Sparse bitmap implementation. |
There was a problem hiding this comment.
Documentation is very sparse (excuse the pun). Should at least describe how we are packing nonces into the StorageMap<u64, u128> data structure.
vgeddes
approved these changes
Apr 11, 2025
claravanstaden
merged commit 8dae6ac
into
snowbridge-v2-audit-fixes
37 of 43 checks passed
|
Review required! Latest push from author must always be reviewed |
claravanstaden
pushed a commit
that referenced
this pull request
May 2, 2025
* Credit to reward address * convert account (#18) * Fallback reward to relayer * Cleaup * Improve inbound tests --------- Co-authored-by: Vincent Geddes <117534+vgeddes@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: SNO-1475