Skip to content

Audit Issue 15: Correct call indexes in system v2 pallet #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
claravanstaden merged 3 commits into from
Apr 14, 2025
Merged

Audit Issue 15: Correct call indexes in system v2 pallet #15

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
44f90ae
fix call indexes
claravanstaden Apr 8, 2025
74e5e3b
update call indexes
claravanstaden Apr 14, 2025
386ab4f
Merge branch 'snowbridge-v2-audit-fixes' into sv2-audit-issue-15-fixed
claravanstaden Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions bridges/snowbridge/pallets/system-v2/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ pub mod pallet {
/// - `impl_address`: The address of the implementation contract.
/// - `impl_code_hash`: The codehash of the implementation contract.
/// - `initializer`: Optionally call an initializer on the implementation contract.
#[pallet::call_index(3)]
#[pallet::call_index(0)]
#[pallet::weight((<T as pallet::Config>::WeightInfo::upgrade(), DispatchClass::Operational))]
pub fn upgrade(
origin: OriginFor<T>,
Expand Down Expand Up @@ -159,7 +159,7 @@ pub mod pallet {
/// Fee required: No
///
/// - `origin`: Must be `GovernanceOrigin`
#[pallet::call_index(4)]
#[pallet::call_index(1)]
#[pallet::weight((<T as pallet::Config>::WeightInfo::set_operating_mode(), DispatchClass::Operational))]
pub fn set_operating_mode(origin: OriginFor<T>, mode: OperatingMode) -> DispatchResult {
let origin_location = T::GovernanceOrigin::ensure_origin(origin)?;
Expand All @@ -179,7 +179,7 @@ pub mod pallet {
/// - `sender`: The original sender initiating the call on AH
/// - `asset_id`: Location of the asset (relative to this chain)
/// - `metadata`: Metadata to include in the instantiated ERC20 contract on Ethereum
#[pallet::call_index(0)]
#[pallet::call_index(2)]
#[pallet::weight(<T as pallet::Config>::WeightInfo::register_token())]
pub fn register_token(
origin: OriginFor<T>,
Expand Down
Loading