Skip to content

Audit Issue 15: Correct call indexes in system v2 pallet#15

Merged
claravanstaden merged 3 commits into
snowbridge-v2-audit-fixesfrom
sv2-audit-issue-15-fixed
Apr 14, 2025
Merged

Audit Issue 15: Correct call indexes in system v2 pallet#15
claravanstaden merged 3 commits into
snowbridge-v2-audit-fixesfrom
sv2-audit-issue-15-fixed

Conversation

@claravanstaden
Copy link
Copy Markdown
Owner

Resolves: SNO-1468

Copy link
Copy Markdown

@yrong yrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Copy Markdown

@vgeddes vgeddes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have the extrinsics and call indexes defined in this order please:

  1. upgrade
  2. set_operating_mode
  3. register_token

Because upgrading more important than registering token.

@github-actions github-actions Bot requested a review from yrong April 14, 2025 12:00
@github-actions
Copy link
Copy Markdown

Review required! Latest push from author must always be reviewed

# Conflicts:
#	bridges/snowbridge/pallets/system-v2/src/lib.rs
@claravanstaden
Copy link
Copy Markdown
Owner Author

@vgeddes addressed in 74e5e3b.

@claravanstaden claravanstaden requested a review from vgeddes April 14, 2025 12:02
@claravanstaden claravanstaden merged commit 3a06db9 into snowbridge-v2-audit-fixes Apr 14, 2025
79 of 173 checks passed
@claravanstaden claravanstaden deleted the sv2-audit-issue-15-fixed branch April 14, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants