New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show arg/command descriptions in dynamic completions #5056

Merged

epage merged 5 commits into clap-rs:master from ModProg:dynamic-completions-help

Aug 7, 2023

Contributor

ModProg commented Jul 31, 2023

based on #5048

epage changed the title ~~dynamic completions help~~ Show arg/command descriptions in dynamic completions

ModProg mentioned this pull request

fish support for native completions #3917

Open

2 tasks

ModProg force-pushed the dynamic-completions-help branch from 7dc6e41 to 16ded80 Compare

July 31, 2023 18:43

epage mentioned this pull request

Filter and order completions based on input and importance for native completions #5058

Closed

epage reviewed

View reviewed changes

clap_complete/src/dynamic/shells/fish.rs Outdated Show resolved Hide resolved

epage reviewed

View reviewed changes

clap_complete/src/shells/zsh.rs Outdated Show resolved Hide resolved

epage reviewed

View reviewed changes

clap_complete/src/generator/utils.rs Outdated Show resolved Hide resolved

epage reviewed

View reviewed changes

clap_complete/src/dynamic/completer.rs Outdated Show resolved Hide resolved

ModProg force-pushed the dynamic-completions-help branch from 3ef0467 to 49b6116 Compare

July 31, 2023 19:36

Contributor Author

ModProg commented Jul 31, 2023

the dedup thing seams to be a rust-analyzer bug.

epage reviewed

View reviewed changes

clap_complete/src/dynamic/completer.rs Show resolved Hide resolved

epage reviewed

View reviewed changes

clap_complete/tests/testsuite/dynamic.rs Outdated Show resolved Hide resolved

ModProg force-pushed the dynamic-completions-help branch from 49b6116 to 71ce87c Compare

August 1, 2023 11:44

epage reviewed

View reviewed changes

clap_complete/src/dynamic/completer.rs Outdated Show resolved Hide resolved

epage reviewed

View reviewed changes

clap_complete/examples/exhaustive.rs Outdated Show resolved Hide resolved

epage reviewed

View reviewed changes

clap_complete/examples/exhaustive.rs Outdated Show resolved Hide resolved

ModProg force-pushed the dynamic-completions-help branch from 71ce87c to 863a88b Compare

August 3, 2023 09:19

Contributor Author

ModProg commented Aug 3, 2023

It would be nice if the snapshots from the completion output were snapshot files as well, would make updating easier.

ModProg force-pushed the dynamic-completions-help branch from 863a88b to f7f7803 Compare

August 3, 2023 09:42


          refactor(complete): Stop using generate utils in dynamic

b613548

ModProg force-pushed the dynamic-completions-help branch from f7f7803 to b524634 Compare

August 3, 2023 09:51

Member

epage commented Aug 3, 2023

It would be nice if the snapshots from the completion output were snapshot files as well, would make updating easier.

I'm hoping to one day support in-code snapshot updating

Also, most tests should be on the shell-agnostic code. The shell-specific code should mostly be tested to ensure shell integration works

epage reviewed

View reviewed changes

clap_complete/src/dynamic/completer.rs Outdated Show resolved Hide resolved

ModProg commented

View reviewed changes

clap_complete/tests/testsuite/dynamic.rs Show resolved Hide resolved

ModProg added 2 commits

August 4, 2023 01:20


          feat(complete): Show help in dynamic completions

bdefebf


          test(complete): Test help escaping

5b10a9d

ModProg force-pushed the dynamic-completions-help branch from c9faaa4 to e0eb645 Compare

August 3, 2023 18:21

epage reviewed

View reviewed changes

clap_complete/tests/testsuite/dynamic.rs Outdated Show resolved Hide resolved

epage reviewed

View reviewed changes

clap_complete/tests/testsuite/dynamic.rs Outdated Show resolved Hide resolved

epage reviewed

View reviewed changes

clap_complete/tests/testsuite/dynamic.rs Outdated Show resolved Hide resolved


          test(complete): Helper for asserting dynamic completions

65b9c2b

ModProg force-pushed the dynamic-completions-help branch from e0eb645 to 65b9c2b Compare

August 7, 2023 06:47


          test(complete): Help for possible value

aa3f47c

ModProg force-pushed the dynamic-completions-help branch from 4bf88cb to aa3f47c Compare

August 7, 2023 07:03

ModProg requested a review from epage

August 7, 2023 07:29

Member

epage commented Aug 7, 2023

Thanks for all of your work on this!

epage merged commit fe04b3c into clap-rs:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet