-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fish support for native completions #3917
Comments
I wanted to start on this, looking at the current structure with bash, would it make sense to move the bash mod into a separate file, and could/should some of the bash code be reused instead of duplicated, and therefore extracted into a shared module for utils? |
I mostly kept it a single file for ease of prototyping. It will make sense to split it into another file. Please do that in a separate commit from other work so its easier to track whats going on |
Have the PR setup now for review. Still open things, especially in the handling of more complex functionality in handling parsing errors or arguments taking multiple values. Also there might be some ways to unify code with claps actual parsing logic, but as I'm not familiar with it, I skipped that for now. |
Yeah, I hope to find a way to merge it one day but I figure its better for us to learn what is expected first |
Yeah makes sense. There is probably also a bunch of parsing/error handling that can be skipped for completions. |
|
See #3166 for more context
Tasks
The text was updated successfully, but these errors were encountered: