Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added editor initialization manual performance test #6124

Merged
merged 3 commits into from
Jan 23, 2020
Merged

Added editor initialization manual performance test #6124

merged 3 commits into from
Jan 23, 2020

Conversation

mlewand
Copy link
Contributor

@mlewand mlewand commented Jan 22, 2020

Suggested merge commit message (convention)

Tests: Added editor setData manual performance test. Part of #5880.


Additional information

File utils.js was placed above of manual test directory, as otherwise it was parsed as a manual test and could not be included at all to the test.

@Reinmar Reinmar mentioned this pull request Jan 22, 2020
9 tasks
@jodator jodator self-requested a review January 23, 2020 11:33
@jodator jodator self-assigned this Jan 23, 2020
Copy link
Contributor

@jodator jodator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As in comments - the steps doesn't look optional and the UI could be similar to first PR.

HTML payload.
</div>

<style>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<style> could be moved to the top

}
</style>

<div id="editor_small" class="editor"></div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The <hr> would be nice here as in other manual tests (small issue but would be nice to have same visual pattern for those tests).

@@ -0,0 +1,8 @@
# Performance: editor initialization

1. You might want to enable devtools profiling.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This steps should describe to other guys how to measure performance (in short). So I'd not use might or optional here - just the steps required to perform the check.

@@ -0,0 +1,11 @@
<div id="test-controls">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those files are mangled from another PR. For atomic PRs we can't create branches from one another (only from master). The problem might be shared code but for those quick PRs we should minimize the round-trip time for review.

ps.: I'll see how this will look after merging #6103.

@jodator jodator merged commit 67414e6 into master Jan 23, 2020
@jodator jodator deleted the i/5880b branch January 23, 2020 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants