-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added editor initialization manual performance test #6124
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As in comments - the steps doesn't look optional and the UI could be similar to first PR.
HTML payload. | ||
</div> | ||
|
||
<style> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<style>
could be moved to the top
} | ||
</style> | ||
|
||
<div id="editor_small" class="editor"></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The <hr>
would be nice here as in other manual tests (small issue but would be nice to have same visual pattern for those tests).
@@ -0,0 +1,8 @@ | |||
# Performance: editor initialization | |||
|
|||
1. You might want to enable devtools profiling. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This steps should describe to other guys how to measure performance (in short). So I'd not use might
or optional
here - just the steps required to perform the check.
@@ -0,0 +1,11 @@ | |||
<div id="test-controls"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those files are mangled from another PR. For atomic PRs we can't create branches from one another (only from master
). The problem might be shared code but for those quick PRs we should minimize the round-trip time for review.
ps.: I'll see how this will look after merging #6103.
Suggested merge commit message (convention)
Tests: Added editor setData manual performance test. Part of #5880.
Additional information
File
utils.js
was placed above of manual test directory, as otherwise it was parsed as a manual test and could not be included at all to the test.