Added editor setData manual performance test #6103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jodator
reviewed
Jan 23, 2020
jodator
reviewed
Jan 23, 2020
jodator
reviewed
Jan 23, 2020
Co-Authored-By: Maciej <[email protected]>
Co-Authored-By: Maciej <[email protected]>
|
Ture, the only case when you can gut tell this are these "omg it takes so long that I'm going to take a coffee" kind of cases, which luckily I'm not aware of in our editor 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Internal: Added editor setData manual performance test. Part of #5880.
Additional information
In this micro PR I added a manual test for calling setData on the editor.
Fixtures (so the data that we consider small/medium/large) are extracted as separate files to keep it DRY. Fun fact, it couldn't be
.htmlfile as it would not be served by our Karma/Webpack config so I went with.txt. Fixtures contain a dummy placeholder as setting it with proper content will be done in another PR.