Changed the default icon for BallonEditor. #14914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkflpc
approved these changes
Sep 11, 2023
| const editBlockLabel = t( 'Edit block' ); | ||
|
|
||
| const isDragDropBlockToolbarPluginLoaded = editor.plugins.has( 'DragDropBlockToolbar' ); | ||
| const label = isDragDropBlockToolbarPluginLoaded ? `${ editBlockText } \n${ dragToMoveText }` : editBlockLabel; |
There was a problem hiding this comment.
Why the space before new line? Does it help to adjust the text?
There was a problem hiding this comment.
No, a leftover - nice catch 👍 will fix it right away.
There was a problem hiding this comment.
Fixed in 5ec1cb5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other (ui): Changed the default icon for BallonEditor and add ability to customize it.
Closes #14646 .
Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.
Answer on question about
icons: 👉 #14646 (comment)That's why i decided to extend the
NESTED_TOOLBAR_ICONSwith only two more icons.