Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Drag & drop + Balloon block, intro] Change the default icon #14646

Closed
Tracked by #13933
Witoso opened this issue Jul 24, 2023 · 7 comments · Fixed by #14914
Closed
Tracked by #13933

[Drag & drop + Balloon block, intro] Change the default icon #14646

Witoso opened this issue Jul 24, 2023 · 7 comments · Fixed by #14914
Assignees
Labels
package:clipboard squad:core Issue to be handled by the Core team. type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@Witoso
Copy link
Member

Witoso commented Jul 24, 2023

We plan to change the default icon of the Balloon block editor. The new icon will be more recognizable as a drag handle.

Internal figma.

If you'd like to see this improvement implemented, add a 👍 reaction to this post.

@Witoso Witoso added type:improvement This issue reports a possible enhancement of an existing feature. package:clipboard squad:core Issue to be handled by the Core team. labels Jul 24, 2023
@Witoso Witoso mentioned this issue Jul 24, 2023
16 tasks
@Witoso
Copy link
Member Author

Witoso commented Aug 21, 2023

	blockToolbar: {
		items: [
			'bold',
			'italic',
			'link'
		],
		icon: 'pilcrow' // or SVG.
	},

☝️ possible configuration approach.

@Witoso Witoso changed the title [Drag & drop + Balloon block] Change the default icon [Drag & drop + Balloon block, intro] Change the default icon Aug 21, 2023
@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Aug 22, 2023
@pszczesniak pszczesniak self-assigned this Aug 28, 2023
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Aug 29, 2023
@pszczesniak
Copy link
Contributor

pszczesniak commented Aug 29, 2023

Got a questions about the button of the Balloon block editor:

  • should the label (tooltip shown on hover) also mention about edit possibility? for example Click to edit block / drag to move or something similar, cause now it will covers two functionality at once,
  • what kind of cursor should it be on hover? Should it stay as default as it is now or maybe change it into grab?

cc @dagdzi , @oleq

WDYT about multi-line tooltip?
Screenshot 2023-08-29 at 12 05 18

@pszczesniak
Copy link
Contributor

pszczesniak commented Aug 30, 2023

@oleq could you explain why here 👇

 https://github.com/ckeditor/ckeditor5/blob/52231a24d8e2721e91d589d58cdf921557660899/packages/ckeditor5-ui/src/toolbar/toolbarview.ts#L50:L58 we got this list cropped instead of using all existing icons?

We want to use this icon list as a predefined list for configuration/customizing the icon of Balloon Block Editor toolbar.

@dagdzi
Copy link

dagdzi commented Aug 30, 2023

@pszczesniak

I think in this case displaying information about two functionalities in the tooltip is better than displaying only one of them (because when we have information only about one functionality it kind of suggests that the other functionality is not present).

In the case of the cursor, maybe the solution is to change it to grab cursor only when grabbing and otherwise have default one?

@pszczesniak
Copy link
Contributor

In the case of the cursor, maybe the solution is to change it to grab cursor only when grabbing and otherwise have default one?

@dagdzi was thinking about same thing also, but this will be moved as a follow-up i think 🙂 Thank You!

@CKEditorBot CKEditorBot added status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Sep 4, 2023
@oleq
Copy link
Member

oleq commented Sep 7, 2023

https://github.com/ckeditor/ckeditor5/blob/52231a24d8e2721e91d589d58cdf921557660899/packages/ckeditor5-ui/src/toolbar/toolbarview.ts#L50:L58 we got this list cropped instead of using all existing icons?

Because then, all production builds of all editors would get bloated with dozens of bulky icons that would only be used by like 5% of users and increase the size of distributed packages by many kilobytes. It's a usability vs. size kind of trade-off.

What we could do is make all built-in icons (all icons in a specific production build) available at some central point so at least they could be re-used across features. If you think this is a good idea, please vote for #12496.

arkflpc added a commit that referenced this issue Sep 11, 2023
…-the-default-icon

Other (ui): Changed the default icon for `BallonEditor` and add ability to customize it. Closes #14646.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Sep 11, 2023
@CKEditorBot CKEditorBot added this to the iteration 67 milestone Sep 11, 2023
@godai78
Copy link
Contributor

godai78 commented Sep 21, 2023

@Witoso - is this configurable they way you put it?

Also, I believe the configuration part should rather be added here: https://ckeditor.com/docs/ckeditor5/latest/features/toolbar/blocktoolbar.html#configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:clipboard squad:core Issue to be handled by the Core team. type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants