Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type:module to packages #14219

Closed
wants to merge 28 commits into from
Closed

Conversation

filipsobol
Copy link
Member

@filipsobol filipsobol commented May 23, 2023

Suggested merge commit message (convention)

Fix: Add type:module to packages to indicate they are ESM. See #13673.


This PR depends on ckeditor/ckeditor5-dev#902

@filipsobol filipsobol linked an issue Jun 6, 2023 that may be closed by this pull request
@filipsobol filipsobol requested a review from arkflpc July 4, 2023 15:01
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you describe what has happened with this file?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@filipsobol filipsobol marked this pull request as draft September 22, 2023 08:10
@filipsobol
Copy link
Member Author

Continued in #15540

@filipsobol filipsobol closed this Dec 15, 2023
@filipsobol filipsobol deleted the ck/13673-improve-vite-support branch December 15, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants