Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ESM support #902

Merged
merged 4 commits into from
Dec 14, 2023
Merged

Improve ESM support #902

merged 4 commits into from
Dec 14, 2023

Conversation

filipsobol
Copy link
Member

@filipsobol filipsobol commented Jul 4, 2023 •
edited by pomek
Loading

Suggested merge commit message (convention)

Fix (tests): Fixed processing of the ESM packages when running automated and manual tests. See ckeditor/ckeditor5#13673.

MINOR BREAKING CHANGE (utils): Removed getJavaScriptWithoutImportExtensions() loader introduced in #885.

@filipsobol filipsobol requested a review from pomek July 4, 2023 12:52
@filipsobol filipsobol changed the title Ck/13673 improve esm support Improve ESM support Jul 4, 2023
@filipsobol filipsobol linked an issue Jul 4, 2023 that may be closed by this pull request
Make CKEditor 5 packages valid ESM ckeditor/ckeditor5#13673
Closed
@filipsobol filipsobol mentioned this pull request Jul 4, 2023
Closed
@coveralls
Copy link

Coverage Status

coverage: 90.136% (+0.02%) from 90.12%
when pulling e3f4d59 on ck/13673-improve-esm-support
into 433d4fc on master.

pomek
pomek approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@pomek pomek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pomek pomek merged commit 7a06ddb into master Dec 14, 2023
3 checks passed
@pomek pomek deleted the ck/13673-improve-esm-support branch December 14, 2023 13:33
@filipsobol filipsobol removed a link to an issue Dec 15, 2023
Make CKEditor 5 packages valid ESM ckeditor/ckeditor5#13673
Closed
@filipsobol filipsobol linked an issue Dec 15, 2023 that may be closed by this pull request
Make CKEditor 5 packages valid ESM ckeditor/ckeditor5#13673
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martnpaneq martnpaneq martnpaneq approved these changes

@pomek pomek pomek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make CKEditor 5 packages valid ESM
4 participants
@filipsobol @coveralls @pomek @martnpaneq