Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It should be possible to make selection of a single cell. #6347

Closed
Reinmar opened this issue Feb 27, 2020 · 1 comment · Fixed by ckeditor/ckeditor5-table#263
Closed

It should be possible to make selection of a single cell. #6347

Reinmar opened this issue Feb 27, 2020 · 1 comment · Fixed by ckeditor/ckeditor5-table#263
Labels
package:table type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 30 (v18...

Comments

@Reinmar
Copy link
Member

Reinmar commented Feb 27, 2020

📝 Provide detailed reproduction steps (if any)

  1. Start selection in cell A
  2. Drag to the left (to select e.g. 3 cells)
  3. Drag back to the right to move the selection back to cell A.

✔️ Expected result

It should select that single cell A.

❌ Actual result

It keeps selection of a minimum of two cells.

📃 Other details

We need to fix the logic there. Right now we care fore "multi-range cell selections" but single-cell selections are fine too.

May be related #6346.
@Reinmar Reinmar added the type:bug This issue reports a buggy (incorrect) behavior. label Feb 27, 2020
@Reinmar Reinmar mentioned this issue Feb 27, 2020
Closed
@Reinmar Reinmar added this to the iteration 30 milestone Feb 27, 2020
@Reinmar
Copy link
Member Author

Reinmar commented Feb 27, 2020

BONUS: Copy that selection of 2 cells and you get an error. Will automatically start working when we switch the logic to handle single-cell selections.

This was referenced Feb 28, 2020
Closed
Merged
Reinmar added a commit to ckeditor/ckeditor5-table that referenced this issue Mar 6, 2020
@Reinmar
Merge pull request #263 from ckeditor/i/6114b
e6eb3cd 
Internal: Rewritten the base selection handling. Closes ckeditor/ckeditor5#6114. Closes ckeditor/ckeditor5#6330. Closes ckeditor/ckeditor5#6346. Closes ckeditor/ckeditor5#6347.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:table type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 30 (v18.0.0)
Development

Successfully merging a pull request may close this issue.

Rewritten the base selection handling ckeditor/ckeditor5-table
2 participants
@Reinmar @mlewand