Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting a table cell (or cells) through a model does not render a nice table selection #6346

Closed
Reinmar opened this issue Feb 27, 2020 · 3 comments · Fixed by ckeditor/ckeditor5-table#263
Assignees
Labels
type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@Reinmar
Copy link
Member

Reinmar commented Feb 27, 2020

📝 Provide a description of the improvement

So. we not only have to handle selection done by the mouse, but also programmatically through the model. This will e.g. fix the undo which is not able to select cells right now.


If you'd like to see this improvement implemented, add a 👍 reaction to this post.

@Reinmar Reinmar added the type:improvement This issue reports a possible enhancement of an existing feature. label Feb 27, 2020
@Reinmar Reinmar added this to the iteration 30 milestone Feb 27, 2020
@jodator
Copy link
Contributor

jodator commented Feb 27, 2020

One thing is this check: https://github.com/ckeditor/ckeditor5-table/blob/3a2e025b7d3132a603d3bd5d814f76f8a5e1bf54/src/tableselection/converters.js#L24 and the TableSelection.hasMultipleCellSelection is used in various places.

The TableSelection does not restore or handle selection set elsewhere (ie by the model modification elsewhere).

This might require:

  1. change for this check
  2. how the TableSelection returns getSelectedTableCells

@Reinmar
Copy link
Member Author

Reinmar commented Feb 27, 2020

It may be worth resolving #6347 when working on this issue.

@jodator
Copy link
Contributor

jodator commented Feb 28, 2020

Check also: #6353.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
2 participants