Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table's InsertTableView takes a long time to render #6193

Closed
mlewand opened this issue Feb 4, 2020 · 2 comments · Fixed by ckeditor/ckeditor5-table#246
Closed

Table's InsertTableView takes a long time to render #6193

mlewand opened this issue Feb 4, 2020 · 2 comments · Fixed by ckeditor/ckeditor5-table#246
Assignees
Labels
package:font package:ui type:improvement This issue reports a possible enhancement of an existing feature. type:performance This issue reports a performance issue or a possible performance improvement.

Comments

@mlewand
Copy link
Contributor

mlewand commented Feb 4, 2020

📝 Provide detailed reproduction steps (if any)

We should improve rendering time of this component.

For instance in case of loading a simple editor with small data sample, it took 60ms, which in turns add up to slow _initToolbar execution. For comparison the entire editor renders in 1.23s so this view alone accounts for almost 5% of the entire initialization time.

Profiler flame chart

✔️ Expected result

Quicker editor UI render 🏃‍♀️

❌ Actual result

InsertTableView takes a lot of time during the initial editor render 🐢 🐢 🐢 🐢 🐢 🐢 🐢 🐢 🐢

📃 Other details

This is a follow-up of #5880.

  • Browser: Chrome
  • OS: Windows (should be cross system)
  • CKEditor version: latest master

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@mlewand mlewand added package:font package:ui type:improvement This issue reports a possible enhancement of an existing feature. type:performance This issue reports a performance issue or a possible performance improvement. labels Feb 4, 2020
@mlewand mlewand mentioned this issue Feb 5, 2020
9 tasks
@Reinmar
Copy link
Member

Reinmar commented Feb 12, 2020

Les recalculations 🏃‍♀️

The performance problem here isn't due to recalculations AFAICT, but simply initializing and rendering a lot of UI when not needed.

@mlewand
Copy link
Contributor Author

mlewand commented Feb 12, 2020

The performance problem here isn't due to recalculations

Yea, I copied the expected / actual from #6194. In case of tables, in fact a lot of items are created - something that we could defer.

Reinmar added a commit to ckeditor/ckeditor5-table that referenced this issue Feb 12, 2020
Other: Implemented lazy loading for the table dropdown. This will reduce editor initialization time. Closes ckeditor/ckeditor5#6193.
@Reinmar Reinmar added this to the iteration 29 milestone Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:font package:ui type:improvement This issue reports a possible enhancement of an existing feature. type:performance This issue reports a performance issue or a possible performance improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants