This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Lazy loading for the table dropdown #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note, this changes the first expected value in "should bind to insertTable command" TC - since the dropdown is open by default, the button should be marked as "on" (active).
|
CI tests will fail in "Table cell paragraph post-fixer should wrap in paragraph $text nodes placed directly in tableCell (on table cell modification)" - that's caused by Chrome 80 bug. Run it on Firefox to have a green ✅ run. |
|
I'm missing a test that the view is indeed lazily created. This is – it does not exist before the dropdown is opened. Like this thing: https://github.com/ckeditor/ckeditor5-special-characters/pull/13/files#r378314398. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other: Implemented lazy loading for the table dropdown. This will reduce editor initialization time. Closes ckeditor/ckeditor5#6193.