Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing labels for nested editables #11837

Closed
Comandeer opened this issue May 27, 2022 · 1 comment · Fixed by #11880
Closed

Missing labels for nested editables #11837

Comandeer opened this issue May 27, 2022 · 1 comment · Fixed by #11880
Assignees
Labels
domain:accessibility This issue reports an accessibility problem. package:image package:table squad:features Issue to be handled by the Features team. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@Comandeer
Copy link
Member

📝 Provide detailed reproduction steps (if any)

  1. Open https://ckeditor.com/docs/ckeditor5/latest/examples/builds/classic-editor.html
  2. Launch VoiceOver or other screen reader
  3. Focus the caption of the image.

✔️ Expected result

The editable should be announced as an image caption.

❌ Actual result

There is no label.

❓ Possible solution

The caption can be announced as, e.g. "Caption for <image's alt> image".

📃 Other details

  • Browser: all
  • OS: all
  • First affected CKEditor version: …
  • Installed CKEditor plugins: image, table

The same issue exists for other nested editables, e.g. table cells.


If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@Comandeer Comandeer added type:bug This issue reports a buggy (incorrect) behavior. package:image package:table domain:accessibility This issue reports an accessibility problem. squad:features Issue to be handled by the Features team. labels May 27, 2022
@mlewand
Copy link
Contributor

mlewand commented Jun 1, 2022

We don't have any specific a11y markup for the figcaption editable. In a11y tree it's not even visible as an editable element (at least in Google Chrome).

To start off we need to set role attribute of editable element to a textbox. Secondly we need to add a label with the value proposed by @Comandeer (in case there's no alt text on image the label should be simply "Caption for the image").

@mmotyczynska mmotyczynska self-assigned this Jun 3, 2022
@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Jun 3, 2022
oleq added a commit that referenced this issue Jul 11, 2022
…ested-editables

Fix (image,widget): Allowed setting an accessible label in the `toWidgetEditable()` helper. Added missing labels for assistive technologies to image captions. Closes #11837.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Jul 11, 2022
@Reinmar Reinmar added this to the iteration 55 milestone Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:accessibility This issue reports an accessibility problem. package:image package:table squad:features Issue to be handled by the Features team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants