Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Style dropdown] Integration with document (advanced) lists #11590

Closed
Tracked by #11574
oleq opened this issue Apr 7, 2022 · 1 comment · Fixed by #13878
Closed
Tracked by #11574

[Style dropdown] Integration with document (advanced) lists #11590

oleq opened this issue Apr 7, 2022 · 1 comment · Fixed by #13878
Assignees
@niegowski
Labels
package:list package:style squad:core Issue to be handled by the Core team. support:2 An issue reported by a commercially licensed client. type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Milestone
iteration 63 (v38...

Comments

@oleq
Copy link
Member

oleq commented Apr 7, 2022 •
edited by Witoso
Loading

📝 Provide a description of the new feature

Document (advanced) lists use different model attribute names than the default htmlAttributes. This is why the styles feature (command) does not interact with them. A dedicated integration is necessary.

(edited by @Witoso, 30.03.2022)

Acceptance criteria:

  • given I have Document lists plugin and the style definition of ol, when I'm in a list item, or select multiple list items or multiple lists, and select the style, then style should be applied to one (or more) ol elements.
  • given I have Document lists plugin and the style definition of ul, when I'm in a list item, or select multiple list items or multiple lists, and select the style, then style should be applied to one (or more) ul elements.
  • given I have Document lists plugin and the style definition of li, when I'm in a list item, or select multiple list items or multiple lists, and select the style, then style should be applied to one (or more) li elements.

If you'd like to see this feature implemented, add a 👍 reaction to this post.
@oleq oleq added type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:list package:style labels Apr 7, 2022
@oleq oleq changed the title [Style dropdown] Integration with document lists [Style dropdown] Integration with document (advanced) lists Apr 7, 2022
@Reinmar Reinmar added the squad:core Issue to be handled by the Core team. label Apr 11, 2022
@Reinmar Reinmar mentioned this issue Nov 10, 2022
Closed
14 tasks
@martynawierzbicka martynawierzbicka added the support:2 An issue reported by a commercially licensed client. label Nov 17, 2022
@Reinmar Reinmar mentioned this issue Mar 1, 2023
Closed
@Witoso Witoso mentioned this issue Mar 28, 2023
Closed
@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Mar 29, 2023
@Witoso
Copy link
Member

Witoso commented Apr 6, 2023

Related: #12668

@niegowski niegowski self-assigned this Apr 11, 2023
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Apr 11, 2023
@niegowski niegowski mentioned this issue Apr 13, 2023
Merged
niegowski added a commit that referenced this issue Apr 25, 2023
@niegowski
Merge pull request #13878 from ckeditor/ck/11590-styles-dropdown-docu…
f4ddda8 
…ment-lists

Feature (style): Added support for the Document Lists. Closes #11590. Closes #12668.

Feature (style): The `<figure>` element can be styled. See #11590.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Apr 25, 2023
@CKEditorBot CKEditorBot added this to the iteration 63 milestone Apr 25, 2023
@Witoso Witoso mentioned this issue May 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niegowski niegowski

Labels
package:list package:style squad:core Issue to be handled by the Core team. support:2 An issue reported by a commercially licensed client. type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Milestone
iteration 63 (v38.0.0)
Development

Successfully merging a pull request may close this issue.

Document list basic integration with styles dropdown. ckeditor/ckeditor5
6 participants
@Reinmar @oleq @niegowski @Witoso @CKEditorBot @martynawierzbicka