Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Styles dropdown] Refine missing integrations between Styles dropdown and block widgets and document lists #13585

Closed
Reinmar opened this issue Mar 1, 2023 · 1 comment
Assignees
Labels
package:style squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".

Comments

@Reinmar
Copy link
Member

Reinmar commented Mar 1, 2023

In order to unblock #11577 and #11590 we need to remind what kind of issues we stumbled upon when working on these integrations for the fist time.

@Reinmar Reinmar added type:task This issue reports a chore (non-production change) and other types of "todos". package:style labels Mar 1, 2023
@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Mar 1, 2023
@Reinmar Reinmar added the squad:core Issue to be handled by the Core team. label Mar 1, 2023
@niegowski niegowski self-assigned this Mar 2, 2023
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Mar 6, 2023
@niegowski
Copy link
Contributor

Widgets

The only written reason behind not handling them in MVC1 that I could find was this:

There’s a too deep clash with e.g. image styles and predefined sizes.

My idea for this: We could extend the styles dropdown API so that other features (like image style and image resize) could register their styles together with their custom implementation. This way it could use the dedicated commands and model attributes instead of using GHS for those features. This would essentially make the styles dropdown a central point of different styles repository with a single UI and it would be an integrator decision whether some styles should be applied with GHS underneath or it should use some feature's commands. Even the headings dropdown could register into the styles dropdown to make it a single dropdown for both (styles and headings). Of course as an option for an integrator.

Document Lists

I'm not sure but it feels like it was a timing issue and both features were released and developed at the same time.

@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Mar 9, 2023
@CKEditorBot CKEditorBot added this to the upcoming milestone Mar 9, 2023
@Reinmar Reinmar modified the milestones: upcoming, iteration 61 Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:style squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Development

No branches or pull requests

3 participants