Add options to test command #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Rebased onto latest |
f1ames
approved these changes
Oct 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using it for #6 however it would be helpful for any other changes, so I've extracted it here.
What's new in this PR:
minimalist, it is used inckeditor5-vueandckeditor4-vue.ng testby spawning new process. Command line options are smuggled to child process env.options.url(aliasu) which is an url to be included by Karma. It's purpose to quickly pass different src of CKEditor.options.watch(aliasw) which tells karma to watch for changes in files and rerun tests whenever changes occur. This option is originally supported by Angular CLI however with new way of running tests it has to be reimplemented.Closes #34.
Closes #8.