Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable classic editor #6

Closed
engineering-this opened this issue Nov 18, 2018 · 3 comments · Fixed by #36
Closed

Enable classic editor #6

engineering-this opened this issue Nov 18, 2018 · 3 comments · Fixed by #36
Milestone

Comments

@engineering-this
Copy link
Contributor

engineering-this commented Nov 18, 2018

CKEditor component is forcing divarea plugin. We should should enable use of the classic editor.

Currently we are unable to fix this issue. Usage of framed editor in Angular can cause some memory leaks, and console errors. Angular doesn't allow cleanup before elements are removed from DOM, ngOnDestroy is called when elements are already removed.

There is a feature request on Angular GH: angular/angular#17404
Once it is resolved we can allow the usage of classic editor.

@f1ames
Copy link
Contributor

f1ames commented May 30, 2019

This issue will be fixed by upstream issue - ckeditor/ckeditor4#3128 and then we can enable classic editor in the integration.

@f1ames f1ames added this to the 1.0.0 milestone May 30, 2019
@engineering-this
Copy link
Contributor Author

I wonder if we should keep divarea as default editor type, so no breaking changes are introduced? Or change it to classic?

If we accept breaking changes during beta phase, we can consider going further, and allow type=inline and type=classic only. This would allow us to get rid of logic to ensure divarea plugin included in config. In that case if you want to have divarea, just add that plugin to your config.

@wwalc
Copy link
Member

wwalc commented Jun 6, 2019

Since we had a beta release so far, there is no need for keeping backwards compatibility. It should be enough to explain any changes in the changelog and the blog post.

This was referenced Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants