Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken contributing link on PyPI #726

Merged

Conversation

staticdev
Copy link
Contributor

@staticdev staticdev commented Dec 8, 2021

Closes cjolowicz/cookiecutter-hypermodern-python#1091

Copy link
Owner

@cjolowicz cjolowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

The problem with your approach is that it will silently switch versions on Read the Docs.

@cjolowicz
Copy link
Owner

Better keep the github-only marker and use the full GitHub URL (main branch) instead of a relative link.

pros:

  • RTD versioning isn't broken by silently switching to latest
  • GitHub readers stay on GitHub

cons:

  • GitHub readers might switch branch when clicking the link

I think the pros outweigh the cons.

Like you say, PyPI readers will get the GitHub version which is less polished. But it's the Contributor Guide, contributors want to go to GitHub anyway 😉

@staticdev
Copy link
Contributor Author

@cjolowicz oh I see the problem. Ok, I fix that later today.

@cjolowicz cjolowicz merged commit f0019bc into cjolowicz:main Dec 11, 2021
Copy link
Owner

@cjolowicz cjolowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@staticdev staticdev deleted the bug/fix-broken-pypi-contributing-link branch December 11, 2021 17:17
@cjolowicz cjolowicz added the documentation Improvements or additions to documentation label Dec 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken link on PyPI for Contributor Guide
2 participants