Use XDG_STATE_HOME environment variable as a preference above HOME

[jaapjansma]

Fix for #195

One can set the environment variable XDG_STATE_HOME
This will take precedence over the HOME environment variable.

[totten]

Thanks for moving this forward, @jaapjansma!

The test-failures seem to be some unrelated issue in master. (I haven't yet figured out a sufficient routine to focus-in on the problem - but will look at it.)

I wonder if you've had a chance to read the definitions from https://specifications.freedesktop.org/basedir-spec/latest/#variables -- there are a few variables, and the choice of vars somewhat subjective (but not completely).

Like here's my impression

• UpgradeDbCommand::getUpgradeFile() - Sounds like closest fit to XDG_STATE_HOME?
• Config::getFileName() and CvPlugins - These sound like XDG_CONFIG_HOME might be closer fit?

[jaapjansma]

I agree with you for following the standard. However using cv on a well used hosting platform as CiviHosting one needs to set two environment variables to get cv working. Because on CiviHosting those environment variables are not set.

So this requires additional documentation and makes the tool probably less user friendly.

[jaapjansma]

I have updated the PR to reflect the standard of XDG Base Directories