Prefer a dictionary to ternary logic #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsf9k
added
the
improvement
The dictionary can handle more than two cases (should that ever be required) and is cleaner.
jsf9k
force-pushed
the
improvement/prefer-dict-to-ternary-logic
branch
from
07a6319
to
8ce82fc
Compare
|
The failing Fedora 40 checks will be fixed by #58. |
dv4harr10
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request removes the ternary logic that determines the architecture of the system package to install and instead uses a dictionary.
💭 Motivation and context
The dictionary can handle more than two cases (should that ever be required) and is cleaner.
🧪 Testing
All automated tests pass.
✅ Pre-approval checklist