Use a drop-in config snippet instead of editing /etc/systemd/journald.conf directly
#58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsf9k
added
improvement
jsf9k
added a commit
to cisagov/freeipa-server-packer
that referenced
this pull request
May 22, 2024
…ch-agent This is being done for testing purposes and can be reverted once cisagov/ansible-role-cloudwatch-agent#58 has been merged.
12 tasks
jsf9k
added
the
blocked
3 tasks
jsf9k
force-pushed
the
improvement/use-drop-in-conf-file
branch
from
49a31b1
to
bcd1456
Compare
jsf9k
removed
the
blocked
jsf9k
force-pushed
the
improvement/use-drop-in-conf-file
branch
from
2b7e839
to
bddd063
Compare
6 tasks
This is the method that is preferred in the documentation: https://man7.org/linux/man-pages/man5/journald.conf.5.html#CONFIGURATION_DIRECTORIES_AND_PRECEDENCE
… files directly This is a better way to test that the configuration changes are actually being utilized by systemd-journald.
All platforms we support use systemd, so we need not use a handler to call systemctl daemon-reload.
systemd-journald.socket fails to start under QEMU emulation starting with systemd version 256, so starting with that version the systemd-journald service cannot be restarted either. Right now we support this case, but we can't test it until we have native ARM64 runners. See issue #61 for more details.
jsf9k
force-pushed
the
improvement/use-drop-in-conf-file
branch
from
04e817b
to
b0c30a7
Compare
jsf9k
requested review from
dav3r,
felddy,
jasonodoom and
mcdonnnj
as code owners
mcdonnnj
approved these changes
Jun 18, 2024
Co-authored-by: Nick <[email protected]>
Co-authored-by: Nick <[email protected]>
jsf9k
force-pushed
the
improvement/use-drop-in-conf-file
branch
from
0e7990c
to
b6766b4
Compare
dv4harr10
approved these changes
Jun 20, 2024
jsf9k
added a commit
to cisagov/freeipa-server-packer
that referenced
this pull request
Jun 20, 2024
…-agent We can do this now that cisagov/ansible-role-cloudwatch-agent#58 has been merged.
jsf9k
added a commit
to cisagov/freeipa-server-packer
that referenced
this pull request
Sep 24, 2024
…ch-agent This is being done for testing purposes and can be reverted once cisagov/ansible-role-cloudwatch-agent#58 has been merged.
jsf9k
added a commit
to cisagov/freeipa-server-packer
that referenced
this pull request
Sep 24, 2024
…-agent We can do this now that cisagov/ansible-role-cloudwatch-agent#58 has been merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request modifies the Ansible role to use a drop-in config snippet instead of editing
/etc/systemd/journald.confdirectly. It also reworks themoleculetest code.💭 Motivation and context
/etc/systemd/journald.confdoes not exist on Fedora 40.systemd-analyze cat-configis a better way (than checking config files directly) to verify that the configuration changes are actually being utilized bysystemd-journald.🧪 Testing
All automated tests pass.
✅ Pre-approval checklist