digestcheck: take a list of files as input #3145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtardy
added
area/ci
The exclude part wasn't working because it was only matching on the name of the file and not on the whole path, specifically the directory structure. Instead of using exclude-dir, let's just take the directory or the files directly as input so that the user can specify before which files needs to be included/excluded or not. Signed-off-by: Mahe Tardy <[email protected]>
mtardy
force-pushed
the
pr/mtardy/digestcheck-fix
branch
from
0542a87 to
7788bad
Compare
mtardy
changed the title
This will partially prevent this workflow to spot issues in outdated or wrong multi-arch SHA256 that haven't been touched in the PR and should be updated elsewhere. It will not be perfect as it's as precise as files and not lines so it might still spot issues that were not changed by this PR but I don't want to spend too much rewriting this script that has the very nice property to dump file name and file lines using the grep output. It seems it would require more change to use the git diff -U0 output instead. Signed-off-by: Mahe Tardy <[email protected]>
mtardy
force-pushed
the
pr/mtardy/digestcheck-fix
branch
from
7788bad to
3a38f0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will partially prevent this workflow to spot issues in outdated or
wrong multi-arch SHA256 that haven't been touched in the PR and should
be updated elsewhere. It will not be perfect as it's as precise as files
and not lines so it might still spot issues that were not changed by
this PR but I don't want to spend too much rewriting this script that
has the very nice property to dump file name and file lines using the
grep output. It seems it would require more change to use the git diff
-U0 output instead.