Skip to content

Commit

Permalink
workflow: pass only the git diff files for digestcheck
Browse files Browse the repository at this point in the history
This will partially prevent this workflow to spot issues in outdated or
wrong multi-arch SHA256 that haven't been touched in the PR and should
be updated elsewhere. It will not be perfect as it's as precise as files
and not lines so it might still spot issues that were not changed by
this PR but I don't want to spend too much rewriting this script that
has the very nice property to dump file name and file lines using the
grep output. It seems it would require more change to use the git diff
-U0 output instead.

Signed-off-by: Mahe Tardy <[email protected]>
  • Loading branch information
mtardy committed Nov 19, 2024
1 parent a59e9c3 commit 3a38f0f
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion .github/workflows/digestcheck.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ jobs:
steps:
- name: Checkout code
uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
with:
fetch-depth: 0 # because we also need the main branch

- name: Install crane
env:
Expand All @@ -26,4 +28,5 @@ jobs:
- name: Check digests
env:
TERM: xterm-color
run: ./contrib/digestcheck.sh ${{ github.workspace }}
BASE_REF: ${{ github.base_ref }}
run: git diff --name-only origin/$BASE_REF | xargs ./contrib/digestcheck.sh

0 comments on commit 3a38f0f

Please sign in to comment.