Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock the connectivity command #2448

Merged
merged 1 commit into from
Mar 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions .github/workflows/dont-modify-connectivity.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
name: Don't modify the connectivity command

on:
pull_request: {}

jobs:
check_changes:
name: Fail if the connectivity command is getting modified
runs-on: ubuntu-22.04
steps:
- name: Check if the connectivity command is getting modified
uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
id: check
with:
filters: |
connectivity:
- 'connectivity/**'
- 'cli/connectivity.go'

- name: Fail if the connectivity command is getting modified
if: steps.check.outputs.connectivity == 'true'
run: |
echo "Don't modify the connectivity command. @michi-covalent is holding a lock."
exit 1
3 changes: 3 additions & 0 deletions connectivity/suite.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
// SPDX-License-Identifier: Apache-2.0
// Copyright Authors of Cilium

// Package connectivity defines tests executed by the "cilium connectivity test"
// command. Do not modify this package. It's being moved to cilium/cilium repo as
// a part of https://github.com/cilium/design-cfps/pull/9.
package connectivity

import (
Expand Down
Loading