Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock the connectivity command #2448

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Lock the connectivity command #2448

merged 1 commit into from
Mar 28, 2024

Conversation

michi-covalent
Copy link
Contributor

No description provided.

Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth to also add a package-level godoc comment stating the lock.

Signed-off-by: Michi Mutsuzaki <[email protected]>
@michi-covalent michi-covalent marked this pull request as ready for review March 28, 2024 01:49
@michi-covalent michi-covalent requested review from a team as code owners March 28, 2024 01:49
@michi-covalent michi-covalent requested review from tklauser and aanm March 28, 2024 01:49
Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it!

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 28, 2024
@michi-covalent michi-covalent merged commit 0a07fc1 into main Mar 28, 2024
13 of 14 checks passed
@michi-covalent michi-covalent deleted the pr/michi/lock branch March 28, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants