Fix: Creating deployments for another repository fails with Not Found
#69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamoneill
changed the title
Error creating GitHub deployment: Not Found
liamoneill
changed the title
Error creating GitHub deployment: Not FoundNot Found
|
Hey @chrnorm, thanks for your work on this action! Are you still accepting fixes? Would love to get this upstream if possible. |
|
Hey @liamoneill - my apologies for the delay here. Thankyou so much for the fix! |
No apology necessary! Thanks so much for the awesome work! |
|
@liamoneill this has been released in v2.0.4 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the action from failing when creating a deployment for another repo then where the workflow is running from.
Error from logs:
This was caused by the
createDeploymentStatusrequest hardcoding the repo & owner from context instead of using the repo that deployment was created under.I've tested the change in workflows that both create deployments on themselves and other repos and the fix applied to be working as expected.