use owner and repo for deployment status request #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@scotthogan thanks for this PR! I've just merged and released #69 in v2.0.4 which I believe deals with the same issue, although I do agree with your change to kebab-case for the input. I've given you a mention in the release notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes an error that occurs when specifying a different
ownerandrepo(and GitHubtoken) when the request tocreateDeploymentStatusis attempted. The error:The cause seems to be that this request is using the owner/repo from the context object (i.e. the repo the workflow is run from) rather than resolving these from the inputs as the
createDeploymentrequest does.By using the same previously resolved
ownerandrepovariables in this call, it resolves this issue.