Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for NMT base and NMT master #504

Merged
merged 6 commits into from
Jul 9, 2024

Conversation

erlend-aasland
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.74%. Comparing base (c4560da) to head (6fa2986).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #504      +/-   ##
==========================================
+ Coverage   67.90%   68.74%   +0.83%     
==========================================
  Files          26       26              
  Lines        3116     3116              
  Branches      527      527              
==========================================
+ Hits         2116     2142      +26     
+ Misses        858      837      -21     
+ Partials      142      137       -5     

see 2 files with indirect coverage changes

test/test_nmt.py Outdated Show resolved Hide resolved
@erlend-aasland
Copy link
Contributor Author

More yak shave for #500.

Copy link
Collaborator

@acolomb acolomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this is impressive. Thank you very much for your diligence. I could never have come up with all these test cases...

test/test_nmt.py Outdated Show resolved Hide resolved
test/test_nmt.py Outdated Show resolved Hide resolved
test/test_nmt.py Outdated Show resolved Hide resolved
@acolomb acolomb mentioned this pull request Jul 9, 2024
@erlend-aasland
Copy link
Contributor Author

FTR, I will follow up with a PR for hardening the NMT slave tests.

test/test_nmt.py Outdated Show resolved Hide resolved
@erlend-aasland erlend-aasland requested a review from acolomb July 9, 2024 10:11
@acolomb acolomb merged commit fa74236 into christiansandberg:master Jul 9, 2024
3 checks passed
@erlend-aasland erlend-aasland deleted the test/nmt-base branch July 9, 2024 10:18
@erlend-aasland erlend-aasland mentioned this pull request Jul 10, 2024
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants