-
Notifications
You must be signed in to change notification settings - Fork 200
Tests: harden TestNetwork #505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests: harden TestNetwork #505
Conversation
erlend-aasland
commented
Jul 8, 2024
- make tests deterministic
- use cleanup hooks
- make tests deterministic - use cleanup hooks
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #505 +/- ##
==========================================
+ Coverage 67.90% 67.93% +0.03%
==========================================
Files 26 26
Lines 3116 3116
Branches 527 527
==========================================
+ Hits 2116 2117 +1
+ Misses 858 856 -2
- Partials 142 143 +1 |
I did some experiments with a full-blown CI matrix1 and discovered that Footnotes
|
As long as GitHub covers the additional computation costs, sure why not. Although I think Python 3.8 (oldest supported) and the two most recent Python releases (3.11, 3.12 currently) should be sufficient. |
- check the number of triggers - roughly check the interval
Sounds good. I'll pair it with a matrix of operating systems, post landing this PR. |
I really appreciate the thoroughness of your reviews; thanks a lot! |
Oh, just noticed my commit message erroneously referred to heartbeats in the periodicity stuff. Though this is lower level, I just got confused. Again, thank YOU for putting in all this work in the first place. Otherwise, there would be less to review but also no improvements. |
No sweat, you're fine; as you said yourself, no Git log is perfect :) |
Hah, eating my words already today! This is not deterministic enough, and it will break on macOS CI 😆 So much for my "pretty certain" #505 (comment). So, I learned that BTW, I still can't get reproducible tests using |
Well, apparently only the
Haven't really looked at the implementation, but I thought it was just a lower level call in the underlying python-can library. It's probably a difference between waiting / polling messages and installing a notifier callback (which |
Yep, sounds plausible. |