Skip to content

Improve Smoke Tests execution time #918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Improve Smoke Tests execution time #918

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2cade89
Initial plan
Copilot Mar 2, 2026
274a7ee
Address review comments: fix exit code checks, remove dead code, repl…
Copilot Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions test/smoke-tests.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,13 @@
setlocal enabledelayedexpansion

:: Parse command line arguments
set "THROTTLE_LIMIT=4"
set "USE_PRODUCTION=false"
set "USE_DOCKER=false"

:parse_args
if "%~1"=="" goto :main
if /i "%~1"=="-throttlelimit" (
set "THROTTLE_LIMIT=%~2"
:: Accepted for compatibility but not used (script runs sequentially)
shift
shift
goto :parse_args
Expand All @@ -34,7 +33,6 @@ shift
goto :parse_args

:main
echo ThrottleLimit: %THROTTLE_LIMIT%
echo UseProduction: %USE_PRODUCTION%
echo UseDocker: %USE_DOCKER%

Expand Down Expand Up @@ -164,8 +162,11 @@ echo.
echo === Pre-restoring packages ===
echo.
dotnet restore .\ConsoleApp\ConsoleApp.slnx --nologo -v q
call :throw_on_native_failure
dotnet restore .\ConsoleApp\ConsoleApp.Core.slnx --nologo -v q
call :throw_on_native_failure
dotnet restore .\Apizr\Sample.csproj --nologo -v q
call :throw_on_native_failure

:: ==========================================
:: Phase 2: Settings-file tests
Expand Down
25 changes: 16 additions & 9 deletions test/smoke-tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,9 @@ function RunTests
if ($BuildFromSource -and -not $UseDocker)
{
Write-Host "dotnet publish ../src/Refitter/Refitter.csproj -c Release -o bin -f net9.0"
Start-Process "dotnet" -Args "publish ../src/Refitter/Refitter.csproj -c Release -o bin -f net9.0" -NoNewWindow -PassThru | Wait-Process
$publishProcess = Start-Process "dotnet" -Args "publish ../src/Refitter/Refitter.csproj -c Release -o bin -f net9.0" -NoNewWindow -PassThru
$publishProcess | Wait-Process
if ($publishProcess.ExitCode -ne 0) { throw "dotnet publish failed!" }

Write-Host "refitter --version"
$p = Start-Process "./bin/refitter" -Args "--version" -NoNewWindow -PassThru
Expand All @@ -216,9 +218,15 @@ function RunTests
# Phase 1: Pre-restore packages
# ==========================================
Write-Host "`r`n=== Pre-restoring packages ===`r`n"
Start-Process "dotnet" -Args "restore ./ConsoleApp/ConsoleApp.slnx --nologo -v q" -NoNewWindow -PassThru | Wait-Process
Start-Process "dotnet" -Args "restore ./ConsoleApp/ConsoleApp.Core.slnx --nologo -v q" -NoNewWindow -PassThru | Wait-Process
Start-Process "dotnet" -Args "restore ./Apizr/Sample.csproj --nologo -v q" -NoNewWindow -PassThru | Wait-Process
$p = Start-Process "dotnet" -Args "restore ./ConsoleApp/ConsoleApp.slnx --nologo -v q" -NoNewWindow -PassThru
$p | Wait-Process
if ($p.ExitCode -ne 0) { throw "dotnet restore ./ConsoleApp/ConsoleApp.slnx failed!" }
$p = Start-Process "dotnet" -Args "restore ./ConsoleApp/ConsoleApp.Core.slnx --nologo -v q" -NoNewWindow -PassThru
$p | Wait-Process
if ($p.ExitCode -ne 0) { throw "dotnet restore ./ConsoleApp/ConsoleApp.Core.slnx failed!" }
$p = Start-Process "dotnet" -Args "restore ./Apizr/Sample.csproj --nologo -v q" -NoNewWindow -PassThru
$p | Wait-Process
if ($p.ExitCode -ne 0) { throw "dotnet restore ./Apizr/Sample.csproj failed!" }

# ==========================================
# Phase 2: Settings-file tests (individual generate + build)
Expand Down Expand Up @@ -379,7 +387,7 @@ function RunTests
Write-Host "Standard generation tasks: $($standardTasks.Count)"
Write-Host "NetCore generation tasks: $($netCoreTasks.Count)"

# Execute standard generation in parallel batches
# Execute standard generation tasks sequentially
RunGenerationTasks -tasks $standardTasks -processPath $processPath -useDocker $UseDocker

# ==========================================
Expand All @@ -397,9 +405,9 @@ function RunTests
$customNameSpec = "./OpenAPI/v3.0/petstore.json"
$customNameArgs = "--multiple-interfaces ByEndpoint --operation-name-template ExecuteAsync"
$customNameOutput = "./GeneratedCode/MultipleInterfacesWithCustomName_generateonly.cs"
$customNameCmd = "$processPath $customNameSpec --namespace GenerateOnly.MultipleInterfacesWithCustomName --output $customNameOutput --no-logging $customNameArgs"
Write-Host $customNameCmd
Invoke-Expression $customNameCmd
$customNameCmdArgs = "$customNameSpec --namespace GenerateOnly.MultipleInterfacesWithCustomName --output $customNameOutput --no-logging $customNameArgs"
Write-Host "$processPath $customNameCmdArgs"
StartRefitter -processPath $processPath -arguments $customNameCmdArgs -useDocker:$UseDocker
if (-not (Test-Path $customNameOutput)) { throw "Generate-only test failed: MultipleInterfacesWithCustomName" }
Remove-Item $customNameOutput -Force
Write-Host "Generate-only test passed: MultipleInterfacesWithCustomName"
Expand All @@ -425,7 +433,6 @@ function RunTests

@("https://petstore3.swagger.io/api/v3/openapi.json", "https://petstore3.swagger.io/api/v3/openapi.yaml") | ForEach-Object {
$url = $_
$urlFormat = if ($url.EndsWith(".json")) { "json" } else { "yaml" }
$namespace = "PetstoreFromUri"
$outputPath = "PetstoreFromUri.generated.cs"

Expand Down
Loading