Skip to content

Improve Smoke Tests execution time#918

Closed
christianhelle with Copilot wants to merge 2 commits into
mainfrom
copilot/sub-pr-915
Closed

Improve Smoke Tests execution time#918
christianhelle with Copilot wants to merge 2 commits into
mainfrom
copilot/sub-pr-915

Conversation

Copilot AI commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

Addresses review feedback on the smoke test refactor: fixes silent failure modes, removes dead code, and corrects a Docker-incompatible code path.

smoke-tests.ps1

  • Check dotnet publish exit code; throw on failure instead of silently continuing
  • Check exit codes for all three dotnet restore calls in Phase 1
  • Replace Invoke-Expression in Phase 4b with StartRefitter — fixes broken Docker mode (the old form produced docker ./spec.json ... without the required run --rm -v ... prefix)
  • Fix comment: generation is sequential, not parallel
  • Remove unused $urlFormat variable

smoke-tests.bat

  • Add call :throw_on_native_failure after each dotnet restore — consistent with publish error handling
  • Remove unused THROTTLE_LIMIT variable; the script runs sequentially and never consumed it (flag still accepted for CLI compatibility)

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Base automatically changed from smoke-tests to main March 2, 2026 22:31
…ace Invoke-Expression

Co-authored-by: christianhelle <710400+christianhelle@users.noreply.github.com>
Copilot AI changed the title [WIP] Improve smoke tests execution time Improve Smoke Tests execution time Mar 2, 2026
@sonarqubecloud

sonarqubecloud Bot commented Mar 2, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants