Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sorting symbols when the field is null #496

Merged
merged 1 commit into from
Aug 27, 2022

Conversation

habibalkhabbaz
Copy link
Contributor

Description

This PR is going to fix the #491 issue.
We were assigning big numbers for nullable fields when sorting our monitoring symbols such as Sell - Profit which makes the sorting in Mongo DB unstable.
Based on that, we rely on $symbol field instead of big numbers when the fields are null to make the sorting functionality work as expected.

Related Issue

#491

Motivation and Context

How Has This Been Tested?

Tests have been written to verify that.

Screenshots (if appropriate):

Refer to #491

@chrisleekr chrisleekr merged commit 4aebd15 into chrisleekr:master Aug 27, 2022
@chrisleekr chrisleekr added the bug Something isn't working label Aug 27, 2022
@chrisleekr chrisleekr linked an issue Aug 27, 2022 that may be closed by this pull request
@chrisleekr
Copy link
Owner

Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort by Sell - Profit not working as expected
2 participants