Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort by Sell - Profit not working as expected #491

Closed
uhliksk opened this issue Aug 24, 2022 · 4 comments · Fixed by #496
Closed

Sort by Sell - Profit not working as expected #491

uhliksk opened this issue Aug 24, 2022 · 4 comments · Fixed by #496
Labels
bug Something isn't working

Comments

@uhliksk
Copy link
Contributor

uhliksk commented Aug 24, 2022

Version

v0.0.89(165d110)

Description

There are some symbols with not open trades on multiple pages while other are missing completely.

To Reproduce

  1. Add multiple symbol.
  2. Sort by Sell - Profit (desc)
  3. See some not traded symbols are listed on multiple pages, some symbols are not listed at all

Expected Behaviours

There should be no duplicates or missing symbols when sorting is applied.

Screenshots

Not traded symbols XMRBUSD, ATOMBUSD, EOSBUSD and ZECBUSD listed on page 5, 6 and 7 at once.

Page 5:
image

Page 6:
image

Page 7:
image

Additional context

Not traded symbol I mean symbol with trading enabled but no buy orders executed yet. There is no sell profit calculated for those symbols affected which is probably causing a confusion for the sorting algorithm.

@uhliksk uhliksk added the bug Something isn't working label Aug 24, 2022
@habibalkhabbaz
Copy link
Contributor

Hello @uhliksk

I think this will be solved by changing the following line to '$symbol' instead of assigning big numbers because all symbols will have the same number and cannot be sorted properly:

then: sortByDesc ? -999 : 999,

@uhliksk
Copy link
Contributor Author

uhliksk commented Aug 25, 2022

Hello @habibalkhabbaz

Thank you for the suggestion. I'm little bit busy those days so I'm just accumulating the issues. :) You can create PR if you wish or I can fix with other issues over the weekend.

@habibalkhabbaz
Copy link
Contributor

Hi @uhliksk
It is solved in #496 and it is merged by @chrisleekr

@uhliksk
Copy link
Contributor Author

uhliksk commented Aug 28, 2022

Hi @habibalkhabbaz
Nice. I'm still busy a little bit. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants