Sort by Sell - Profit not working as expected

[uhliksk]

Version

v0.0.89(165d110)

Description

There are some symbols with not open trades on multiple pages while other are missing completely.

To Reproduce

1. Add multiple symbol.
2. Sort by Sell - Profit (desc)
3. See some not traded symbols are listed on multiple pages, some symbols are not listed at all

Expected Behaviours

There should be no duplicates or missing symbols when sorting is applied.

Screenshots

Not traded symbols XMRBUSD, ATOMBUSD, EOSBUSD and ZECBUSD listed on page 5, 6 and 7 at once.

Page 5:

Page 6:

Page 7:

Additional context

Not traded symbol I mean symbol with trading enabled but no buy orders executed yet. There is no sell profit calculated for those symbols affected which is probably causing a confusion for the sorting algorithm.

[habibalkhabbaz]

Hello @uhliksk

I think this will be solved by changing the following line to '$symbol' instead of assigning big numbers because all symbols will have the same number and cannot be sorted properly:

binance-trading-bot/app/cronjob/trailingTradeHelper/common.js

Line 981 in 5daea00

then: sortByDesc ? -999 : 999,

[uhliksk]

Hello @habibalkhabbaz

Thank you for the suggestion. I'm little bit busy those days so I'm just accumulating the issues. :) You can create PR if you wish or I can fix with other issues over the weekend.

[habibalkhabbaz]

Hi @uhliksk
It is solved in #496 and it is merged by @chrisleekr

[uhliksk]

Hi @habibalkhabbaz
Nice. I'm still busy a little bit. Thank you.