fix: better pagination #439
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@uhliksk Since all PRs are UI changes, can you make a single PR? |
|
@chrisleekr Yes, I can merge them together. |
|
@uhliksk Yap, once you merge all changes to the single PR and close other PRs, then I will review that PR. Thank you again for your contributions. :) |
|
Merged into #452. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix pagination is showing more pages than actually used and is not compliant with standard pagination methods.
Related Issue
#437
Motivation and Context
The fix will improve the user experience.
How Has This Been Tested?
Tested in my development environment.
Screenshots (if appropriate):
Buttons are visible for available pages only.