Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: better pagination #438

Closed
wants to merge 1 commit into from
Closed

fix: better pagination #438

wants to merge 1 commit into from

Conversation

uhliksk
Copy link
Contributor

@uhliksk uhliksk commented Jul 27, 2022

Description

Fix pagination is showing more pages than actually used and is not compliant with standard pagination methods.

Related Issue

#437

Motivation and Context

The fix will improve the user experience.

How Has This Been Tested?

Tested in my development environment.

Screenshots (if appropriate):

Buttons are visible for available pages only.

image

@uhliksk uhliksk deleted the branch chrisleekr:master July 27, 2022 15:39
@uhliksk uhliksk closed this Jul 27, 2022
@uhliksk uhliksk deleted the master branch July 27, 2022 15:39
@uhliksk uhliksk restored the master branch July 27, 2022 15:40
@uhliksk uhliksk deleted the master branch July 27, 2022 15:41
@uhliksk uhliksk restored the master branch July 27, 2022 15:41
@uhliksk
Copy link
Contributor Author

uhliksk commented Jul 27, 2022

Sorry for the garbage. I had to create new PR #439.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant