Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GHC 9.2 #118

Merged
merged 1 commit into from
Nov 10, 2021
Merged

Support GHC 9.2 #118

merged 1 commit into from
Nov 10, 2021

Conversation

sjakobi
Copy link
Contributor

@sjakobi sjakobi commented Nov 9, 2021

No description provided.

@sjakobi
Copy link
Contributor Author

sjakobi commented Nov 9, 2021

The build failure with GHC 7.10.3 is due to tsurucapital/vector-th-unbox#7.

I see several options for now:

Any preferences?

@chrisdone
Copy link
Owner

Looks like the first option panned out.

I think migrating to gauge would also be fine, but not a big priority unless someone is especially excited about gauge.

Explicitly dropping support for GHC 7.10 seems unnecessary at this point. It’s just a benchmark failure. That’s why I set it to allow fail, but didn’t explicitly update the base lower bound.

@chrisdone
Copy link
Owner

Merging the GHC 9 support, thanks!

@chrisdone chrisdone merged commit 6384700 into chrisdone:master Nov 10, 2021
@sjakobi sjakobi deleted the ghc-9.2 branch November 10, 2021 07:05
@sjakobi
Copy link
Contributor Author

sjakobi commented Nov 10, 2021

It’s just a benchmark failure. That’s why I set it to allow fail, but didn’t explicitly update the base lower bound.

Oh, I hadn't seen that. With haskell-ci, if you want to preserve a certain setting, it's best to put it into the cabal.haskell-ci config, e.g.

allow-failures: == 7.10.3

Future runs of haskell-ci regenerate will then take this setting into account.

BTW, could you publish the bumped bound on base via a Hackage revision? Thanks!

@chrisdone
Copy link
Owner

I've published a new revision.

@chrisdone
Copy link
Owner

Thanks @sjakobi Looks like lucid didn't need any changes to work on GHC 9.2, which is good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants