Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failures with GHC < 8 #7

Closed
sjakobi opened this issue Nov 9, 2021 · 6 comments
Closed

Build failures with GHC < 8 #7

sjakobi opened this issue Nov 9, 2021 · 6 comments

Comments

@sjakobi
Copy link

sjakobi commented Nov 9, 2021

See https://matrix.hackage.haskell.org/#/package/vector-th-unbox

For 7.10.3, the error is

Data/Vector/Unboxed/Deriving.hs:4:14:
    Unsupported extension: TemplateHaskellQuotes
@pacak
Copy link
Member

pacak commented Nov 9, 2021

Due to a06a865, I don't think this support is coming back.

@sjakobi
Copy link
Author

sjakobi commented Nov 9, 2021

I don't really have an opinion on which GHC versions this package supports. I just encountered this issue in a package that depends on vector-th-unbox via criterion (via statistics).

In any case, could you tighten the lower bound on base for v0.2.2 with a Hackage revision?

@pacak
Copy link
Member

pacak commented Nov 9, 2021

Sounds like a good idea, will do.

@sjakobi
Copy link
Author

sjakobi commented Nov 10, 2021

Thanks for the revision! :)

@sjakobi sjakobi closed this as completed Nov 10, 2021
@phadej
Copy link

phadej commented Nov 10, 2021

FYI, you can add other-extensions: TemplateHaskellQuotes (in revision!) and it would had similar effect, but were semantically more correct.

@phadej
Copy link

phadej commented Nov 10, 2021

@sjakobi as you are a Hackage Trustee, don't hesitate to make revisions yourself, especially it's in version which solver picks up eagerly (i.e. latest ones) and e.g. breaks some other packages CI etc. (= that's our job).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants