move to task manager module to src/server by tsullivan · Pull Request #2 · chrisdavies/kibana

tsullivan · 2018-09-04T20:56:10Z

I have a plugin that schedules a task, and looks like:

      const client = await server.taskManager.getTaskManager();
      client.schedule({
        taskType: 'check_shards',
        runAt: immediately(),
        attempts: 0,
        status: 'idle',
        params: { index: '.monitoring-es-6-*' },
        state: {},
        user: 'elastic',
        scope: 'foo',
      });

I'm not 100% on the namings I chose, but this should help us get further with the other pieces we'll need to build.

tsullivan · 2018-09-05T16:31:11Z

src/server/task_manager/task_manager.ts

+import { SanitizedTaskDefinition } from './task_pool/task';
+
+function taskManagerFactory(kbnServer: any, server: any, config: any) {
+  let taskManager: TaskManager;


the function being returned here will have to move to a start function that kicks off after all the plugins init

chrisdavies · 2018-09-05T19:51:42Z

x-pack/index.js

    consoleExtensions(kibana),
    notifications(kibana),
-    kueryAutocomplete(kibana),
+    kueryAutocomplete(kibana)


I like the trailing comma! :/

Me too, haha. I just checked out this file from master to revert it. I didn't want a change in an unrelated file to be extra noise

* Prepare control flow to use embeddable factories in add panel * Rewrite saved object finder and add tests * Fix usages of new saved object finder * fix test failures * fix some functional tests and re-introduce makeUrl * fix tests * remove direct hrefs in saved_object_lists * PR review fixes * update snapshot * overwrite width of viz dialog * Update src/legacy/core_plugins/kibana/public/dashboard/top_nav/add_panel.js Co-Authored-By: flash1293 <email@johannes-reuter.de> * Update src/legacy/core_plugins/kibana/public/discover/embeddable/search_embeddable_factory.ts Co-Authored-By: flash1293 <email@johannes-reuter.de> * Update src/legacy/core_plugins/kibana/public/discover/top_nav/open_search_panel.js Co-Authored-By: flash1293 <email@johannes-reuter.de> * Update src/legacy/core_plugins/kibana/public/visualize/wizard/search_selection/search_selection.tsx Co-Authored-By: flash1293 <email@johannes-reuter.de> * Update src/legacy/core_plugins/kibana/public/visualize/wizard/search_selection/search_selection.tsx Co-Authored-By: flash1293 <email@johannes-reuter.de> * Update src/legacy/core_plugins/kibana/public/visualize/wizard/search_selection/search_selection.tsx Co-Authored-By: flash1293 <email@johannes-reuter.de> * fix tests * review fixes #1 * review fixes #2 * dont use classname in functional test * remove call to action button prop * align buttons correctly * fix tests * remove debugging statement * Update src/legacy/core_plugins/kibana/public/dashboard/top_nav/add_panel.js Co-Authored-By: flash1293 <email@johannes-reuter.de> * Update src/legacy/core_plugins/kibana/public/discover/top_nav/open_search_panel.js Co-Authored-By: flash1293 <email@johannes-reuter.de> * review fixes #3 * improve filter behavior and enable it for search wizard * adjust functional tests for new filter behavior * Change translation id due to string change * Update Jest snapshot

* try typescript in kibana `plugin * compile js and ts from protobuf message

* docs: Add test file location -> test runner table * Use scripts/mocha instead of if yarn test:mocha and clarify arguments * docs: add some examples of running tests suites with grep patterns * Split out x-pack testing docs, add test runner column * Split out x-pack testing docs, add test runner column #2 * Use node scripts for jest and split functional runner/server

* Convert simple files to TS * Fix jest tests * Rename saved_objects_client{.js => .ts} * WIP saved_objects_client * saved_objects repository{.js => .ts} * includedFields support string[] for type paramater * Repository/saved_objects_client -> TS * Fix tests and dependencies * Fix saved objects type errors and simplify * saved_objects/index saved_objects/service/index -> ts * Fix saved objects export test after switching to typed mock * Workaround type error * Revert "Workaround type error" This reverts commit de3252267eb2e6bf56a5584d271b55a7afdc1c53. * Correctly type Server.savedObjects.SaveObjectsClient constructor * saved_objects/service/lib/index.{js -> ts} * saved_objects/service/lib/scoped_client_provider{js -> ts} * Typescriptify scoped_client_provider * Fix x-pack jest imports * Add lodash/internal/toPath typings to xpath * Introduce SavedObjectsClientContract We need a way to specify that injected dependencies should adhere to the SavedObjectsClient "contract". We can't use the SavedObjectsClient class itself since it contains the private _repository property which in TS is included in the type signature of a class. * Cleanup and simplify types * Fix repository#delete should return {} * Add SavedObjects repository test for uncovered bug Test for a bug in our previous js implementation that can lead to data corruption and data loss. If a bulkGet request is made where one of the objects to fetch is of a type that isn't allowed, the returned result will include documents which have the incorrect id and type assigned. E.g. the data of an object with id '1' is returned with id '2'. Saving '2' will incorrectly override it's data with that of the data of object '1'. * SavedObject.updated_at: string and unify saved_object / serializer types * Cleanup * Address code review feedback * Don't mock errors helpers in SavedObjectsClient Mock * Address CR feedback * CR Feedback #2 * Add kibana-platform as code owners of Saved Objects * Better typings for SavedObjectsClient.errors * Use unknown as default for generic type request paramater * Bump @types/elasticsearch * Fix types for isForbiddenError * Bump x-pack @types/elasticsearch

* unify modifyUrl on client and server * create BasePath as a separate entity on server * use BasePath class in http server * use BasePath a separate entity on client * use BasePath class on Http service on the client * switch client code to the new api * improve setver http service mocks * address comments #1 * address comments #2 * update docs * add comment why we define own typings

* closes elastic#44349, as well as SDH issue elastic#64 * added tests to cover fix * eslint * Fixed test import

tsullivan added 3 commits September 4, 2018 10:59

revert x-pack change

6012f31

move cancellable to src/utils

b2a014f

move to src/server

6452315

tsullivan commented Sep 5, 2018

View reviewed changes

use afterPluginsInit hook

3630e8c

chrisdavies reviewed Sep 5, 2018

View reviewed changes

tsullivan added 2 commits September 5, 2018 14:44

task_manager.ts rename

1e60301

add a wrapper with a setClient method

79a930e

chrisdavies merged commit 5776633 into chrisdavies:alerting/task-scheduler Sep 6, 2018

tsullivan deleted the alerting/task-scheduler-srcserver branch September 7, 2018 20:01

chrisdavies pushed a commit that referenced this pull request May 8, 2019

try typescript in kibana `plugin (#2)

ff85675

* try typescript in kibana `plugin * compile js and ts from protobuf message

flash1293 added a commit that referenced this pull request Jul 30, 2019

cleanup #2

2195b0e

chrisdavies pushed a commit that referenced this pull request Nov 11, 2019

Fix disco filters #2 (elastic#50061)

29aeec8

* closes elastic#44349, as well as SDH issue elastic#64 * added tests to cover fix * eslint * Fixed test import

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

move to task manager module to src/server#2

move to task manager module to src/server#2
chrisdavies merged 6 commits intochrisdavies:alerting/task-schedulerfrom
tsullivan:alerting/task-scheduler-srcserver

tsullivan commented Sep 4, 2018

Uh oh!

tsullivan Sep 5, 2018

Uh oh!

chrisdavies Sep 5, 2018

Uh oh!

tsullivan Sep 5, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

tsullivan commented Sep 4, 2018

Uh oh!

tsullivan Sep 5, 2018

Choose a reason for hiding this comment

Uh oh!

chrisdavies Sep 5, 2018

Choose a reason for hiding this comment

Uh oh!

tsullivan Sep 5, 2018

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants